Trim the empty lines #956
Closed
Trim the empty lines #956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you seeing any issues with these empty new lines that you felt they have to be removed? #945 was a follow up for #937, which I had as a commit locally that I forgot to include in the same PR, and it introduced a merge conflict with another WIP branch. While we don't have clear guidelines that discourages formatting-only changes, I personally find it unworthy to overwrite git history unless there's a good reason for doing so. |
|
Dear @itingliu , Thank you for your feedback. I am clear now. Let me close this ticket. Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer #945 of @itingliu that trim the empty lines at
Locale_ICU.swift.